Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.gradle: Clear Class-Path from shadowJar manifest #9270

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Jun 13, 2022

The generated Class-Path is simply wrong and it will actually be
attempted to be used at runtime.

Fixes #8606

@ejona86 ejona86 requested a review from YifeiZhuang June 13, 2022 19:05
The generated Class-Path is simply wrong and it will actually be
attempted to be used at runtime.

Fixes grpc#8606
@ejona86
Copy link
Member Author

ejona86 commented Jun 13, 2022

This issue had come up again when working on #9269 as the "thirdparty" sourceSet was being added to Class-Path.

CC @michaelli321

@ejona86 ejona86 merged commit c1c6982 into grpc:master Jun 15, 2022
@ejona86 ejona86 deleted the clear-shadow-classpath branch June 15, 2022 00:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven Build Issue from Setting Class-Path in the jar manifest for grpc-netty-shaded
3 participants